Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #61

Closed
kevinsawicki opened this issue Aug 20, 2013 · 5 comments
Closed

Add CI #61

kevinsawicki opened this issue Aug 20, 2013 · 5 comments

Comments

@kevinsawicki
Copy link
Contributor

We can run builds on our CI machine if atom-shell had a script that can run the specs and terminate when the tests are done, similar to Atom.

@zcbenz What do you think about adding a script/test that wraps script/test.py and handles exiting with errors if specs fail and closing the window once complete?

@zcbenz
Copy link
Member

zcbenz commented Aug 20, 2013

Having both test and test.py seems ambiguous to me, how about using cibuild as name?

And do you prefer the .py suffix if the script is written in python?

@kevinsawicki
Copy link
Contributor Author

We can definitely do it all in script/cibuild but no suffix is the convention.

@zcbenz zcbenz closed this as completed in d160da7 Aug 21, 2013
@kevinsawicki
Copy link
Contributor Author

Awesome, this is now running on our CI machines so you should see pull requests being updated with build status information going forward.

@zcbenz
Copy link
Member

zcbenz commented Aug 24, 2013

@kevinsawicki I opened a PR #65 but the CI didn't run for it.

@kevinsawicki
Copy link
Contributor Author

@zcbenz Thanks for letting me know, should be fixed, #65 now has a build status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants