Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add togglefullscreen menu item role #6166

Merged
merged 6 commits into from Jun 22, 2016
Merged

Add togglefullscreen menu item role #6166

merged 6 commits into from Jun 22, 2016

Conversation

kevinsawicki
Copy link
Contributor

Support a role: 'togglefullscreen' that enter/exits full screen mode for the focused window.

Closes #2811

@kevinsawicki kevinsawicki changed the title Add togglefullscreen role Add togglefullscreen menu item role Jun 21, 2016
@sindresorhus
Copy link
Contributor

On OS X, the label changes from Enter Full Screen to Exit Full Screen when in fullscreen. Not sure whether it should be handled here, but something to keep in mind. These minor details are important for making Electron apps feel native.

@kevinsawicki
Copy link
Contributor Author

On OS X, the label changes from Enter Full Screen to Exit Full Screen when in fullscreen. Not sure whether it should be handled here, but something to keep in mind.

It appears to be handled hear automatically, the menu label seems to update correctly with those values once it contains the togglefullscreen role.

@zcbenz
Copy link
Member

zcbenz commented Jun 22, 2016

👍

@zcbenz zcbenz merged commit 85c163e into master Jun 22, 2016
@zcbenz zcbenz deleted the fullscreen-role branch June 22, 2016 00:58
@erkyrath erkyrath mentioned this pull request Jun 23, 2016
Closed
razzeee added a commit to razzeee/desktop that referenced this pull request Jul 4, 2016
@razzeee
Use togglefullscreen role which is now part of electron
9efcb5d 
electron/electron#6166
@razzeee razzeee mentioned this pull request Jul 16, 2016
Merged
razzeee added a commit to razzeee/desktop that referenced this pull request Jul 17, 2016
@razzeee
Use togglefullscreen role which is now part of electron
ff4175f 
electron/electron#6166
razzeee added a commit to razzeee/desktop that referenced this pull request Jul 17, 2016
@razzeee
Use togglefullscreen role which is now part of electron
0111f12 
electron/electron#6166
razzeee added a commit to razzeee/desktop that referenced this pull request Aug 7, 2016
@razzeee
Use togglefullscreen role which is now part of electron
8c674e5 
electron/electron#6166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinsawicki @sindresorhus @zcbenz