Support forward delete menu item accelerator #6168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if/when/how this might have regressed, but using an
accelerator
ofDelete
no longer works as reported in #5419.This looks to be because
ui::MacKeyCodeForWindowsKeyCode
from Chrome is returningNSDeleteFunctionKey
as the character instead ofNSDeleteCharacter
.From the NSMenuItem keyEquivalent docs:
https://cs.chromium.org/chromium/src/ui/events/keycodes/keyboard_code_conversion_mac.mm?l=75
This pull request adds a check and mapping for this case which gets
Delete
working again as an accelerator for a menu like:Before
### After
Closes #5419