Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window position doesn't restore correctly minimize and restore window #6596

Merged
merged 2 commits into from Jul 26, 2016
Merged

Window position doesn't restore correctly minimize and restore window #6596

merged 2 commits into from Jul 26, 2016

Conversation

liusy182
Copy link
Contributor

close #6574

@zcbenz
Copy link
Member

zcbenz commented Jul 26, 2016

👍

@zcbenz zcbenz merged commit 7b6d74f into electron:master Jul 26, 2016
@simast
Copy link
Contributor

simast commented Jul 31, 2016

This change seems to have introduced a regression when BrowserWindow is created with minWidth property. Minimizing and then restoring the window will restore it to a larger width!

@liusy182 liusy182 mentioned this pull request Jul 31, 2016
Merged
@liusy182
Copy link
Contributor Author

@simast Thanks for spotting this and sorry for my oversight. I have opened a new PR to address this.

@simast simast mentioned this pull request Nov 6, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window position doesn't restore correctly minimize and restore window
3 participants
@liusy182 @zcbenz @simast