don't convert a string to an array buffer

[bridiver]

see brave/muon@d072e61#diff-7452c2b1cabfbce577fef50b254bd08dL33
encoded_data is a base64 string so there is no reason to convert it anyway
cc @deepak1556

[zcbenz]

Can you also change the docs of this field?

I'm cool with this change since it is compatible with most existing code, but you should notice that it doesn't not actually fix the crash you saw, it only works around it.

[bridiver]

Sure, I'll update the docs, but why do you say that it only works around the crash and doesn't fix it?

[bridiver]

with the buffer we get a crash, but with a string we get the cert and everything works. I've had problems with node::Buffer every time I've tried to use it and the only way I've ever successfully sent unmunged binary data is with something like this

const uint8_t* data = reinterpret_cast<const uint8_t*>(body.c_str());
  v8::String::NewFromOneByte(isolate(),
      data, v8::NewStringType::kNormal, body.length()).ToLocalChecked();

[zcbenz]

Sure, I'll update the docs, but why do you say that it only works around the crash and doesn't fix it?

This crash is essentially caused by some weird thing when calling node::Buffer::Copy, since this API is widely used in both Electron and node, you will probably see similar crashes in future.

[zcbenz]

👍