New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate data is now a string #6881

Merged
merged 1 commit into from Aug 17, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Aug 17, 2016

This fixes a breakage caused by #6814 when choosing client certificates.

I'm still nervous about the change since the Chromium API strongly suggests it is binary data, but let's see if any user reports back.

@zcbenz zcbenz merged commit 2e8d7cd into master Aug 17, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3870618 succeeded in 51s
Details
electron-linux-ia32 Build #3870619 succeeded in 47s
Details
electron-linux-x64 Build #3870620 succeeded in 84s
Details
electron-mas-x64 Build #2218 succeeded in 7 min 10 sec
Details
electron-osx-x64 Build #2221 succeeded in 7 min 36 sec
Details
electron-win-ia32 Build #1244 succeeded in 6 min 16 sec
Details
electron-win-x64 Build #1227 succeeded in 6 min 27 sec
Details

@zcbenz zcbenz deleted the data-string branch Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment