Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mac] "quit" is not work after packaging #8687

Closed
wuww5511 opened this issue Feb 15, 2017 · 6 comments
Closed

[mac] "quit" is not work after packaging #8687

wuww5511 opened this issue Feb 15, 2017 · 6 comments
Labels
blocked/need-info ❌ Cannot proceed without more information

Comments

@wuww5511
Copy link

There is a quit option on the menu which is shown after right clicking the dock icon. After packaging the app with electron-packager, the quit option do not work.

@MarshallOfSound
Copy link
Member

@wuww5511 Can you provide a minimal sample application that reproduces the issue, I'm struggling to reproduce on 1.4.x or 1.6.x.

A common cause for this issue is people preventing default on will-quit, you should ensure you aren't doing that as well.

@MarshallOfSound MarshallOfSound added the blocked/need-info ❌ Cannot proceed without more information label Feb 15, 2017
@wuww5511
Copy link
Author

Maybe it is caused by the package "fix-path". When I add "require('fix-path')();", the quit action will not work.

@kevinsawicki
Copy link
Contributor

@wuww5511 can you provide a code snippet for an Electron app using fix-path that fails for you? Thanks.

@wuww5511
Copy link
Author

@kevinsawicki I cloned "https://github.com/electron/electron-quick-start" and added require('fix-path')(); to main.js at the first line. Then I packaged it with "electron-packager". The version of electron is v1.6.3 and the OS is macOS Sierra 10.12.

@wuww5511
Copy link
Author

@kevinsawicki I have made a video. https://www.youtube.com/watch?v=M6E3yWMg9n4

@zcbenz
Copy link
Member

zcbenz commented Jun 6, 2017

I'm closing this since it is caused by a third party module, not an issue of Electron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/need-info ❌ Cannot proceed without more information
Projects
None yet
Development

No branches or pull requests

4 participants