-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-path breaks quit from dock in packaged electron app on OSX #11
Comments
For reference, the hotkey ⌘Q does work, as does Force Quitting the app. |
Maybe a stuck child process? Try https://github.com/sindresorhus/shell-env and check if the promise it returns resolves. Also check with |
My understanding was that any electron app will have at least 1 child process, since there's the main process and the render process, correct? My app doesn't have child processes other than the 2 render processes typical of electron, similar to:
That being said, I've run through @wuww5511 's steps from the linked issue, and I'm not able to reproduce with their minimal app, so there's probably a piece missing. It's definitely still happening in my app (and if I comment out the include of fix-path, quitting works as expected). I'll do a bit more digging and see if I can come up with a set of reproducible steps. |
I spoke too soon -- I can now reliably reproduce this. Apparently there's a difference in the way that the app is executed if you double-click [Your Electron App].app or if you navigate inside the app-bundle and run the shell script there ([Your Electron App].app > Contents > MacOS > [Your Electron App]) -- the former breaks quit, the latter does not, even when using the same app bundle that requires fix-path. I was previously using the latter, which is why I wasn't able to reproduce. Here are the steps to reproduce (on a mac):
Note that if you instead navigate to Here's a git patch showing all of the changes on top of the base electron-quick-start repo required to repro this:
I'll spend a little time looking into shell-env next, but you should be able to reproduce this at will with these steps. As a side note, I'm willing to accept this could be an issue with how electron-packager is bundling things, or with electron itself, but I'd ask for your help filing an issue against those projects if that's determined to be the cause, since electron has already closed this issue once as "due to an issue in a 3rd party module". |
When using Fix-path with Electron and electron-packager, it breaks the ability for the user to quit the application from the dock after packaging. Right clicking the doc-icon and selecting "Quit" does nothing.
This is explained in better detail here: electron/electron#8687 . For a minimal application reproducing the problem, see electron/electron#8687 (comment)
The text was updated successfully, but these errors were encountered: