Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollBounce only bounces once for <webview>s #9233

Closed
javan opened this issue Apr 19, 2017 · 5 comments
Closed

scrollBounce only bounces once for <webview>s #9233

javan opened this issue Apr 19, 2017 · 5 comments

Comments

@javan
Copy link
Contributor

javan commented Apr 19, 2017

  • Electron version: 1.6.7
  • Operating system: macOS 10.12.4

#9134 restored the scrollBounce preference (πŸŽ‰), but it seems to only work once for <webview>s. Works ∞ times for browser windows. :)

scroll-bounce-once

To reproduce, apply these changes to the electron-quick-start app:

diff --git a/index.html b/index.html
index d9161f3..03f0b32 100644
--- a/index.html
+++ b/index.html
@@ -10,6 +10,8 @@
     We are using Node.js <script>document.write(process.versions.node)</script>,
     Chromium <script>document.write(process.versions.chrome)</script>,
     and Electron <script>document.write(process.versions.electron)</script>.
+
+    <webview src="https://github.com" webpreferences="scrollBounce" style="width:760px; height: 400px;"></webview>
   </body>
 
   <script>
diff --git a/package.json b/package.json
index 845fe01..27a55a0 100644
--- a/package.json
+++ b/package.json
@@ -17,6 +17,6 @@
   "author": "GitHub",
   "license": "CC0-1.0",
   "devDependencies": {
-    "electron": "~1.6.2"
+    "electron": "1.6.7"
   }
 }

/cc @kevinsawicki

@kevinsawicki
Copy link
Contributor

Weird, not sure why this is happening, can reproduce.

@javan
Copy link
Contributor Author

javan commented Sep 29, 2017

Quick update: This issue is still present in Electron 1.7 and 1.8.

@steverandy
Copy link

I've just tried v2.0.0-beta.3 and the scrollBounce now works as expected for webview.

@codebytere
Copy link
Member

Seems like this is fixed, closing it out!

@steverandy
Copy link

@codebytere seems there is a regression on Electron v3.0.2.
The scroll bounce only works once for the webview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants