Fix an issue where alwaysOnTop window disappears when restore… #9695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the application icon
atom/browser/native_window_mac.mm
Outdated
| - (void)windowWillMiniaturize:(NSNotification*)notification { | ||
| NSWindow* window = shell_->GetNativeWindow(); | ||
| // store the current status window level to be restored in windowDidDeminiaturize | ||
| level_ = NSStatusWindowLevel; |
There was a problem hiding this comment.
Should this be storing the current level on the window instead of the hard-coded status window level?
Something like:
level_ = [window level];There was a problem hiding this comment.
Yes, It should. Fixed it.
chabou
approved these changes
Jun 25, 2017
kevinsawicki
suggested changes
Jul 13, 2017
| @@ -75,6 +75,7 @@ @interface AtomNSWindowDelegate : NSObject<NSWindowDelegate> { | |||
| @private | |||
| atom::NativeWindowMac* shell_; | |||
| bool is_zooming_; | |||
| int level_; | |||
There was a problem hiding this comment.
I think this should be initialized in initWithShell like the other variables.
spec/api-browser-window-spec.js
Outdated
| @@ -620,6 +620,22 @@ describe('BrowserWindow module', function () { | |||
| }) | |||
| }) | |||
|
|
|||
| describe.only('BrowserWindow.alwaysOnTop() resets level on minimize', function () { | |||
kevinsawicki
approved these changes
Jul 14, 2017
|
Thanks for fixing this @shubham2892 👍 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9170
Reset the custom level when windowWillMiniaturize fires and then restores it when windowDidDeminiaturize fires as suggested in issue.
Before:
After:
