Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BrowserView.fromId(id) #10039

Closed
xywz opened this issue Jul 17, 2017 · 3 comments
Closed

Implement BrowserView.fromId(id) #10039

xywz opened this issue Jul 17, 2017 · 3 comments
Assignees
@poiru
Labels
component/webview

Comments

@xywz
Copy link

xywz commented Jul 17, 2017

Similar to BrowserWindow.fromId(id).
liusy182 added a commit to liusy182/electron that referenced this issue Jul 24, 2017
@liusy182
electron#10039 add BrowserView.fromId
ae7c1ae
@liusy182 liusy182 mentioned this issue Jul 24, 2017
Merged
poiru added a commit that referenced this issue Jul 27, 2017
@poiru
Merge pull request #10097 from liusy182/liusy182-browserview
20ae611 
#10039 add BrowserView.fromId
@poiru
Copy link
Contributor

poiru commented Jul 27, 2017

Fixed by #10039.

@poiru poiru closed this as completed Jul 27, 2017
@promversioning
Copy link

I need this feature, why does it write this "TypeError: BrowserView.fromId is not a function" to me?
I have the latest version of Electron (20.1.0).
Can you help me please?

@promversioning
Copy link

promversioning commented Aug 26, 2022 •
edited
Loading

It is strange because in 5 years no one reported similar problem!
Maybe I'm in wrong ??
var mynewbrowserview= BrowserView.fromId(myid) ;

@promversioning promversioning mentioned this issue Aug 27, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poiru poiru

Labels
component/webview
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zeke @poiru @xywz @promversioning