Add support for css in content_scripts #10076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
reviewed
Jul 24, 2017
jkleinsc
requested changes
Aug 7, 2017
There was a problem hiding this comment.
@alexstrat can you rebase this to resolve the conflict?
Also, could you provide tests for this?
zcbenz
force-pushed
the
add/add-support-for-content_scripts.css
branch
from
3b0d710
to
e1a232e
Compare
|
I have rebased the commit and am merging the pull request, currently we don't have a way to test extension APIs, and adding tests for it is better to be put in another pull request. |
javan
reviewed
Sep 14, 2017
| for (const {code} of script.css) { | ||
| process.once('document-end', () => { | ||
| var node = document.createElement('style') | ||
| node.innerHTML = code |
There was a problem hiding this comment.
Might want to use node.textContent = code instead to ensure child elements aren't created.
There was a problem hiding this comment.
Sounds like a good suggestion, do you want to create a PR for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.