New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for css in content_scripts #10076

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
4 participants
@alexstrat
Contributor

alexstrat commented Jul 20, 2017

No description provided.

@zcbenz

This looks good to me, can you rebase the commit on master?

@jkleinsc jkleinsc self-requested a review Aug 7, 2017

@jkleinsc

@alexstrat can you rebase this to resolve the conflict?
Also, could you provide tests for this?

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 14, 2017

I have rebased the commit and am merging the pull request, currently we don't have a way to test extension APIs, and adding tests for it is better to be put in another pull request.

@zcbenz zcbenz closed this Sep 14, 2017

@zcbenz zcbenz reopened this Sep 14, 2017

@zcbenz zcbenz merged commit fc99785 into electron:master Sep 14, 2017

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5099 succeeded in 12 min
Details
electron-osx-x64 Build #5082 succeeded in 13 min
Details
for (const {code} of script.css) {
process.once('document-end', () => {
var node = document.createElement('style')
node.innerHTML = code

This comment has been minimized.

@javan

javan Sep 14, 2017

Contributor

Might want to use node.textContent = code instead to ensure child elements aren't created.

This comment has been minimized.

@zcbenz

zcbenz Sep 15, 2017

Contributor

Sounds like a good suggestion, do you want to create a PR for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment