Missing file extension in download save dialog

[steverandy]

• Electron version: 1.7.5
• Operating system: macOS 10.12.6

Expected behavior

Save dialog should show filename with the correct extension.

Actual behavior

Extension is missing in the filename on the save dialog window.

How to reproduce

Download a file from a webview.

[zeke]

@steverandy do you have Finder configured to show extensions?

[deltaroe]

We've run into this as well on 1.7.4 and macOS 10.12

With "Show all filename extensions" enabled the extension is added when a file is downloaded, when it's off downloaded files are stripped of their extensions and saved as a bare filename.

Reverting to 1.6.11 resolves the issue for us

[steverandy]

@zeke I don't have the finder config enabled.

When it is enabled, it fixes the issue.
Is this behavior somewhat controlled by the Finder?

[steverandy]

I can confirm that the issue is present since v1.7.4.

[javan]

Confirmed here on macOS 10.12.6 + Electron 1.7.5 too. Curiously, it only happens in a packaged (with electron-packager in my case) .app. The file extension is present when launching the app locally with electron ..

[kevinsawicki]

This looks like a possible regression from #9610, @shubham2892 would you be able to take a look?

[juanmnl]

Same here, macOS Sierra 10.12.6, electron v1.7.5

Finder's "show all filename extensions" fixes it, but I don't expect users to have it enabled by default.

[bennycode]

Encountered the same issue with Electron 1.7.6. When Finder's "Show all filename extensions" is enabled, then files are saved as "file.txt". When the setting is disabled, files will get saved as "file" (without extension).

This behaviour has been different in the past (with Electron 1.6). At that time files were always saved with their extension.

[bennycode]

I tried to cheat the save dialog the following way:

1. Downloading file as Blob using XMLHttpRequest (with responseType of arraybuffer)
2. Creating URL from the Blob (using URL.createObjectURL)
3. Creating anchor tag with href property set to Blob URL
4. Setting download property of anchor tag to fake filename
5. Triggering click on anchor tag

Unfortunately it still doesn't work. You can test it in your own Electron app using the following snippet from the DevConsole within Electron:

const url = window.URL.createObjectURL(new Blob());
const anchor = document.createElement('a');
document.body.appendChild(anchor);
anchor.href = url;
anchor.download = 'file.txt';
anchor.style = 'display: none';
anchor.click();

Although anchor is set to the fixed value file.txt, it depends on the macOS Finder setting if the extension is shown in the save dialog or not.

[dengyaolong]

really harmful change~Many user feedback file download but can't open cause extend name is lost. Any hack?

[javan]

We've had customers report this issue on Windows 10 as well. There's a similar OS setting: http://www.thewindowsclub.com/show-file-extensions-in-windows

[MarshallOfSound]

I just spent a fair time trying to debug this, it looks like our dialog logic is correct (still) but is not being triggered by our download manager delegates. Will investigate more when I get a chance, at the moment my thoughts are somewhere in a Chromium update our code stopped being executed

[dengyaolong]

Now, I prompt the saveDialog and get the filename, add extend name(get by request) when no extend name set by use. Really strange, but work...

[marcoconti83]

Hey @dengyaolong,
thanks for the suggestion on how to "hack" a solution. Could you please explain more how you do it? Any code you can share with us?

[javan]

This looks like a possible regression from #9610

@MarshallOfSound, have you looked into that change as a possible cause?

[dengyaolong]

@marcoconti83 I upload my sample code to https://github.com/dengyaolong/electron-downloader/blob/master/index.js

[marcoconti83]

@dengyaolong thanks!

[bennycode]

@dengyaolong With your 'will-download' listener I am able to get the filename (plus it's extension). 🎉

However, the 'will-download' event only triggers for after the "Save as" dialog has been shown. Is it the same for you? Because I want to fill in the filename (including extension) beforehand.

[dengyaolong]

@bennyn I update the listener, now , you can set 'opts.dir' to set saveDir without dialog.
ps. just call item.setSavePath like my code. https://github.com/dengyaolong/electron-downloader/blob/master/index.js

[poiru]

Fixed by #10469.

[BONDbATIF]

@steverandy @javan
I am using electron v1.8.4 in mac .Still extension issue is not fixed in mac .
Any update ?

[Sharcoux]

I'm stiill having the issue in Windows as of "electron-builder": "22.10.5", and "electron": "^18.1.0",