New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existent option #10542

merged 1 commit into from Sep 24, 2017


None yet
2 participants

EthianWong commented Sep 18, 2017

More details: 8d3e097


This comment has been minimized.

welcome bot commented Sep 18, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@EthianWong EthianWong changed the title from Remove non-existent attributes to Remove non-existent option Sep 18, 2017

@zeke zeke merged commit d552c97 into electron:master Sep 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

welcome bot commented Sep 24, 2017

Congrats on merging your first pull request! 🎉🎉🎉


This comment has been minimized.


zeke commented Sep 24, 2017

Thanks for your contribution!

I wanted to let you know that we're working on a new system for translating Electron's docs. See the readme at electron/electron-i18n for info on how to get started, or you can jump right into translating at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment