BrowserView: Allow dragging of window to screen above menubar #10661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiru
approved these changes
Oct 3, 2017
|
@poiru No, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing the BrowserView drag behavior, I was clever and added logic to prevent the window from being dragged underneath the menubar. Downside: If there's a screen above the menubar, users won't be able to drag the window there.
This code change is only relevant when Electron is built with an SDK < 10.11 (which Electron currently does, sadly). If built with >= 10.11, you'll get native drag behavior. Below, you'll get this fix: It'll check if there's a screen above the menubar, and if so, allow dragging it there.
If you're wondering why all of this is necessary: The BrowserView is above everything else, including all the layers that NSApplication and NSWindow add to our window.