New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update atom-shell-vs-node-webkit.md #10693

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
3 participants
@makerGeek
Contributor

makerGeek commented Oct 4, 2017

nwjs now supports a js script as entrypoint.
cf. http://docs.nwjs.io/en/latest/References/Manifest%20Format/#main

@makerGeek makerGeek requested a review from electron/docs as a code owner Oct 4, 2017

@welcome

This comment has been minimized.

welcome bot commented Oct 4, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@zeke

zeke approved these changes Oct 4, 2017

@zcbenz

zcbenz approved these changes Oct 5, 2017

@zcbenz zcbenz merged commit ee519b7 into electron:master Oct 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 5, 2017

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment