New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #10697 #10873

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@ahmedmohamedali
Contributor

ahmedmohamedali commented Oct 21, 2017

This PR is to fix the crash described in the issue #10697.
The root cause is zoom_controller_ is not initialized for dev tools.

@ahmedmohamedali ahmedmohamedali requested a review from electron/reviewers as a code owner Oct 21, 2017

@ahmedmohamedali ahmedmohamedali changed the title from Electron crashes if user clicks Dev Tools & Zoom options #10697 to Fix for issue #10697 Oct 21, 2017

@deepak1556

👍

@jkleinsc jkleinsc merged commit 67f0eb7 into electron:master Oct 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ahmedmohamedali ahmedmohamedali deleted the ahmedmohamedali:fix_issue_10697 branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment