New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #10697 #10873

Merged

jkleinsc merged 1 commit into electron:master from ahmedmohamedali:fix_issue_10697

Oct 23, 2017

Contributor

ahmedmohamedali commented Oct 21, 2017

This PR is to fix the crash described in the issue #10697.
The root cause is zoom_controller_ is not initialized for dev tools.


          Electron crashes if user clicks Dev Tools & Zoom options electron#10697

463260b

ahmedmohamedali requested a review from a team

October 21, 2017 21:05

ahmedmohamedali changed the title ~~Electron crashes if user clicks Dev Tools & Zoom options #10697~~ Fix for issue #10697

deepak1556 approved these changes

View reviewed changes

Member

deepak1556 left a comment

👍

jkleinsc merged commit 67f0eb7 into electron:master

ahmedmohamedali deleted the fix_issue_10697 branch

October 23, 2017 14:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment