Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix word docs-translation/README.md, CODE_OF_CONDUCT.md #11207

Merged
merged 5 commits into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@kstar0714
Copy link
Contributor

kstar0714 commented Nov 22, 2017

http -> https

kstar0714 added some commits Nov 22, 2017

@kstar0714 kstar0714 requested a review from as a code owner Nov 22, 2017

@kstar0714 kstar0714 changed the title fix word docs-translation/README.md fix word docs-translation/README.md, CODE_OF_CONDUCT.md Nov 22, 2017

@zeke
Copy link
Member

zeke left a comment

ghub.io does not yet support HTTPS

@kstar0714

This comment has been minimized.

Copy link
Contributor Author

kstar0714 commented Nov 22, 2017

ghub.io changed to http.
@zeke Is the other one a pass?

@zeke

zeke approved these changes Nov 22, 2017

Copy link
Member

zeke left a comment

👍

@ckerr ckerr merged commit d92e229 into electron:master Nov 23, 2017

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 23, 2017

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.