Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix word docs-translation/README.md, CODE_OF_CONDUCT.md #11207

Merged
merged 5 commits into from Nov 23, 2017
Merged

fix word docs-translation/README.md, CODE_OF_CONDUCT.md #11207

merged 5 commits into from Nov 23, 2017

Conversation

kstar0714
Copy link
Contributor

http -> https

@kstar0714 kstar0714 requested a review from a team November 22, 2017 01:15
@kstar0714 kstar0714 changed the title fix word docs-translation/README.md fix word docs-translation/README.md, CODE_OF_CONDUCT.md Nov 22, 2017
Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghub.io does not yet support HTTPS

@kstar0714
Copy link
Contributor Author

kstar0714 commented Nov 22, 2017

ghub.io changed to http.
@zeke Is the other one a pass?

Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ckerr ckerr merged commit d92e229 into electron:master Nov 23, 2017
@welcome
Copy link

welcome bot commented Nov 23, 2017

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants