Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot break in 1.8.2 #11430

Closed
bughit opened this issue Dec 13, 2017 · 2 comments
Closed

cannot break in 1.8.2 #11430

bughit opened this issue Dec 13, 2017 · 2 comments
Assignees
@MarshallOfSound
Labels
bug 🪲 bug/regression ↩️ A new version of Electron broke something platform/windows version/1.8.x

Comments

@bughit
Copy link
Contributor

bughit commented Dec 13, 2017 •
edited
Loading

  • Electron version: v1.8.2-beta.3 x86
  • Operating system: win7 x64

Expected behavior

breaking

Actual behavior

no breaking

How to reproduce

  • electron-v1.8.2-beta.3-win32-ia32\electron.exe --inspect-brk
  • attach the chrome dev tools via chrome://inspect
  • debugger should open stopped (it doesn't) other breakpoints will also not be hit

1.7.9 is ok
@ckerr ckerr added the bug/regression ↩️ A new version of Electron broke something label Dec 19, 2017
@MarshallOfSound MarshallOfSound self-assigned this Dec 20, 2017
MarshallOfSound added a commit that referenced this issue Dec 20, 2017
@MarshallOfSound
_debugWaitConnect becomes _breakFirstLine. Fixes #11430
f19f125
@MarshallOfSound MarshallOfSound mentioned this issue Dec 20, 2017
Merged
@alexeykuzmin
Copy link
Contributor

@MarshallOfSound this can be closed, right?

@MarshallOfSound
Copy link
Member

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarshallOfSound MarshallOfSound

Labels
bug 🪲 bug/regression ↩️ A new version of Electron broke something platform/windows version/1.8.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ckerr @alexeykuzmin @bughit @sofianguy @MarshallOfSound