Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrashReport structure in docs does not match API output #11747

Merged
merged 1 commit into from Jan 27, 2018

Conversation

Projects
None yet
2 participants
@timfish
Copy link
Member

timfish commented Jan 27, 2018

Electron 1.7

Docs:

  interface CrashReport {
    date: string;
    ID: number;
  }

Actual output of getLastCrashReport:

{ 
  date: 2018-01-26T21:50:05.000Z,
  id: '989d0469-9eb7-4f70-ba58-3425bc6ffa3b' 
}
CrashReport structure does not match API output
Electron 1.7

Docs:
```typescript
  interface CrashReport {
    date: string;
    ID: number;
  }
```
Actual output of `getLastCrashReport`:
```javascript
{ 
  date: 2018-01-26T21:50:05.000Z,
  id: '989d0469-9eb7-4f70-ba58-3425bc6ffa3b' 
}
```

@timfish timfish requested a review from as a code owner Jan 27, 2018

@timfish timfish changed the title CrashReport structure does not match API output CrashReport structure in docs does not match API output Jan 27, 2018

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Jan 27, 2018

The test failure is unrelated

@MarshallOfSound MarshallOfSound merged commit b0a1575 into electron:master Jan 27, 2018

7 of 8 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.