Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrashReport structure in docs does not match API output #11747

Merged
merged 1 commit into from Jan 27, 2018
Merged

CrashReport structure in docs does not match API output #11747

merged 1 commit into from Jan 27, 2018

Conversation

timfish
Copy link
Contributor

@timfish timfish commented Jan 27, 2018 •
edited

Electron 1.7

Docs:

  interface CrashReport {
    date: string;
    ID: number;
  }

Actual output of getLastCrashReport:

{ 
  date: 2018-01-26T21:50:05.000Z,
  id: '989d0469-9eb7-4f70-ba58-3425bc6ffa3b' 
}

@timfish
CrashReport structure does not match API output
e3383c8 
Electron 1.7

Docs:
```typescript
  interface CrashReport {
    date: string;
    ID: number;
  }
```
Actual output of `getLastCrashReport`:
```javascript
{ 
  date: 2018-01-26T21:50:05.000Z,
  id: '989d0469-9eb7-4f70-ba58-3425bc6ffa3b' 
}
```
@timfish timfish requested a review from a team January 27, 2018 11:21
@timfish timfish changed the title CrashReport structure does not match API output CrashReport structure in docs does not match API output Jan 27, 2018
@MarshallOfSound
Copy link
Member

The test failure is unrelated

@MarshallOfSound MarshallOfSound merged commit b0a1575 into electron:master Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timfish @MarshallOfSound