New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom function with Object.values() #11836

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
2 participants
@kaylie-alexa
Member

kaylie-alexa commented Feb 6, 2018

馃憢 Noticed a TODO comment while browsing the code base, and thought I'd make the quick update

@kaylie-alexa kaylie-alexa requested a review from electron/reviewers as a code owner Feb 6, 2018

@welcome

This comment has been minimized.

welcome bot commented Feb 6, 2018

馃挅 Thanks for opening this pull request! 馃挅

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Feb 6, 2018

Thanks 馃憤

@MarshallOfSound MarshallOfSound merged commit 8c2c7c3 into electron:master Feb 6, 2018

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@welcome

This comment has been minimized.

welcome bot commented Feb 6, 2018

Congrats on merging your first pull request! 馃帀馃帀馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment