New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparent windows losing transparency when devtools detaches #11956

Merged
merged 2 commits into from Feb 21, 2018

Conversation

Projects
None yet
5 participants
@brenca
Member

brenca commented Feb 19, 2018

Fixes #11833

Related chromium issue. This might be a permament fix, since before we relied on the SetBaseBackgroundColorOverride that was called by SetBackgroundOpaque, which is now gonna be cleared when the devtools is detached.

@brenca brenca requested a review from electron/reviewers as a code owner Feb 19, 2018

@brenca brenca changed the title from Reset background color override when devtools is detached to Fix transparent windows losing transparency when devtools detaches Feb 19, 2018

@codebytere

LGTM 👍

@deepak1556

LGTM, Thanks!

@deepak1556 deepak1556 requested a review from zcbenz Feb 19, 2018

@@ -170,7 +170,7 @@ void RendererClientBase::RenderViewCreated(content::RenderView* render_view) {
// If backgroundColor is specified then use it.
std::string name = cmd->GetSwitchValueASCII(switches::kBackgroundColor);
// Otherwise use white background.

This comment has been minimized.

@poiru

poiru Feb 20, 2018

Member

Comment is now out of date. I'd just remove the two comments above since the code is obvious.

@zcbenz

zcbenz approved these changes Feb 21, 2018

The change looks good to me, I'm 👍 removing the outdated comment.

@zcbenz zcbenz merged commit f7ec346 into electron:master Feb 21, 2018

8 of 9 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment