Fix transparent windows losing transparency when devtools detaches #11956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arent window devtools detach
brenca
force-pushed
the
transparent-window-devtools-fix
branch
from
931b0d5
to
d31d208
Compare
brenca
changed the title
poiru
reviewed
Feb 20, 2018
| @@ -170,7 +170,7 @@ void RendererClientBase::RenderViewCreated(content::RenderView* render_view) { | |||
| // If backgroundColor is specified then use it. | |||
| std::string name = cmd->GetSwitchValueASCII(switches::kBackgroundColor); | |||
| // Otherwise use white background. | |||
There was a problem hiding this comment.
Comment is now out of date. I'd just remove the two comments above since the code is obvious.
zcbenz
approved these changes
Feb 21, 2018
This was referenced Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11833
Related chromium issue. This might be a permament fix, since before we relied on the
SetBaseBackgroundColorOverridethat was called bySetBackgroundOpaque, which is now gonna be cleared when the devtools is detached.