New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport (2-0-x) - Fix nil tray title crash #12356

Merged
merged 2 commits into from Mar 23, 2018

Conversation

Projects
None yet
2 participants
@trop
Contributor

trop bot commented Mar 19, 2018

Backport of #12352

See that PR for details.

@trop trop bot requested a review from electron/reviewers as a code owner Mar 19, 2018

@trop trop bot referenced this pull request Mar 19, 2018

Merged

Fix nil tray title crash #12352

@trop trop bot added the backport label Mar 19, 2018

@codebytere

This comment has been minimized.

Member

codebytere commented Mar 23, 2018

arm64 failing on old node issue; not related to this PR. Will merge once MacOS CI passes

@ckerr ckerr merged commit 2903d76 into electron:2-0-x Mar 23, 2018

8 of 10 checks passed

jenkins: arm64/pr-head This commit cannot be built
Details
jenkins: macOS/pr-head This commit is being built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment