Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up #includes to work with both GYP and GN #12882

Merged
merged 1 commit into from May 10, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Copy link
Contributor

nornagon commented May 10, 2018

Include paths no longer include vendor/ or deps/.

@nornagon nornagon requested a review from as a code owner May 10, 2018

@nornagon nornagon requested a review from alexeykuzmin May 10, 2018

@nornagon nornagon referenced this pull request May 10, 2018

Merged

GN build #12837

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented May 10, 2018

The MAS failure looks like flake, so I'm going to go ahead and merge this.

@nornagon nornagon merged commit 3090550 into electron:master May 10, 2018

9 of 10 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nornagon nornagon deleted the nornagon:gn-includes branch May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.