Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: breakpad #includes to work with GN and GYP #12953

Merged
merged 1 commit into from May 15, 2018
Merged

refactor: breakpad #includes to work with GN and GYP #12953

merged 1 commit into from May 15, 2018

Conversation

nornagon
Copy link
Member

No description provided.

@nornagon nornagon requested a review from a team May 15, 2018 17:56
ckerr
ckerr approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nornagon nornagon merged commit c4134c3 into electron:master May 15, 2018
@nornagon nornagon deleted the breakpad-includes branch May 15, 2018 18:33
@rahatarmanahmed rahatarmanahmed mentioned this pull request Oct 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @ckerr