Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: breakpad #includes to work with GN and GYP #12953

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Copy link
Contributor

nornagon commented May 15, 2018

No description provided.

@nornagon nornagon requested a review from as a code owner May 15, 2018

@ckerr

ckerr approved these changes May 15, 2018

Copy link
Member

ckerr left a comment

LGTM.

@nornagon nornagon merged commit c4134c3 into electron:master May 15, 2018

8 of 10 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@nornagon nornagon deleted the nornagon:breakpad-includes branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.