feat: upgrade electron-download to 4.x #12993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change, as it causes the `electron` module to require Node 4.x (which has been EOL'd anyway). Upgrading adds features such as a customizable cache location (via the `ELECTRON_CACHE` environment variable). Originally merged in #10922 but was reverted because it was going into a version of Electron that did not allow breaking changes.
MarshallOfSound
approved these changes
May 18, 2018
|
This has been on the list for a while, can it slot into 3.x before branch @ckerr ? |
This was referenced Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, as it causes the
electronmodule to require Node 4.x (which has been EOL'd anyway).Upgrading adds features such as a customizable cache location (via the
ELECTRON_CACHEenvironment variable).Originally merged in #10922 but was reverted because it was going into a version of Electron that did not allow breaking changes.
The main difference between this and #10922 is that I explicitly added the
enginesdirective (which in NPM generates a warning, but in Yarn throws an error).This should go in the release notes.