New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade electron-download to 4.x #12993

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
3 participants
@malept
Member

malept commented May 18, 2018

This is a breaking change, as it causes the electron module to require Node 4.x (which has been EOL'd anyway).

Upgrading adds features such as a customizable cache location (via the ELECTRON_CACHE environment variable).

Originally merged in #10922 but was reverted because it was going into a version of Electron that did not allow breaking changes.

The main difference between this and #10922 is that I explicitly added the engines directive (which in NPM generates a warning, but in Yarn throws an error).

This should go in the release notes.

feat: upgrade electron-download to 4.x
This is a breaking change, as it causes the `electron` module to require
Node 4.x (which has been EOL'd anyway).

Upgrading adds features such as a customizable cache location (via the
`ELECTRON_CACHE` environment variable).

Originally merged in #10922 but
was reverted because it was going into a version of Electron that did
not allow breaking changes.

@malept malept added the semver/major label May 18, 2018

@malept malept requested a review from electron/reviewers May 18, 2018

@malept malept requested a review from electron/electrocats as a code owner May 18, 2018

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented May 18, 2018

This has been on the list for a while, can it slot into 3.x before branch @ckerr ?

@jkleinsc

Looks good to me

@jkleinsc jkleinsc merged commit 7177e94 into master May 18, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the electron-download-4.x branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment