Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command line argument black-list #13039

Merged
merged 2 commits into from May 22, 2018
Merged

Remove command line argument black-list #13039

merged 2 commits into from May 22, 2018

Conversation

alespergl
Copy link
Contributor

Per our agreement we will instead block all arguments following a URL.

Users of apps that accept multiple URLs, or other arguments following a URL, will need to use a -- argument as a prefix.

Instead block all arguments following a URL.
@alespergl alespergl requested review from ckerr, zcbenz, MarshallOfSound and a team May 22, 2018 14:25
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ckerr ckerr merged commit 93bee69 into master May 22, 2018
@jkleinsc jkleinsc deleted the remove_arg_blacklist branch May 22, 2018 17:17
@alexeykuzmin
Copy link
Contributor

@alespergl Has it been / should it be backported to the 2.0 branch?
cc @ckerr

bendemboski added a commit to adopted-ember-addons/ember-electron that referenced this pull request Oct 4, 2018
electron/electron#13039 caused our tests to fail on windows because we pass URL arguments. So, we need to add a '--' to the arguments to work around the issue.
bendemboski added a commit to adopted-ember-addons/ember-electron that referenced this pull request Oct 5, 2018
electron/electron#13039 caused our tests to fail on windows because we pass URL arguments. So, we need to add a '--' to the arguments to work around the issue.
@DandroidDeveloper
Copy link

Do any of you know the state of --ignore-gpu-blacklist? That flag just seems to be ignored in any version past electron 2.0.0.

#15339

@MarshallOfSound
Copy link
Member

@DandroidDeveloper This PR isn't related to the GPU blacklist

@gannons
Copy link

gannons commented May 7, 2019

@alespergl is this documented?

Hit an issue on Windows 10 where the arguments

--url https://my-service-url.com/api/v1 --location ~/Downloads/args/

caused the app to die before hitting any code in app.js. But when the args were refiddled to

--location ~/Downloads/args/ --url https://my-service-url.com/api/v1

or

-- --url https://my-service-url.com/api/v1 --location ~/Downloads/args/

it works. Does not seem to be a problem on Mac but will catch people out on Windows. It's also a bit unintuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants