New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command line argument black-list #13039

Merged
merged 2 commits into from May 22, 2018

Conversation

Projects
None yet
7 participants
@alespergl
Contributor

alespergl commented May 22, 2018

Per our agreement we will instead block all arguments following a URL.

Users of apps that accept multiple URLs, or other arguments following a URL, will need to use a -- argument as a prefix.

Remove command line argument black-list
Instead block all arguments following a URL.

@alespergl alespergl requested review from ckerr, zcbenz and MarshallOfSound May 22, 2018

@alespergl alespergl requested a review from electron/reviewers as a code owner May 22, 2018

@ckerr

ckerr approved these changes May 22, 2018

LGTM.

@zeke

zeke approved these changes May 22, 2018

@ckerr ckerr merged commit 93bee69 into master May 22, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jkleinsc jkleinsc deleted the remove_arg_blacklist branch May 22, 2018

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Jun 6, 2018

@alespergl Has it been / should it be backported to the 2.0 branch?
cc @ckerr

bendemboski added a commit to felixrieseberg/ember-electron that referenced this pull request Oct 4, 2018

Fix for testing against electron 3 on windows
electron/electron#13039 caused our tests to fail on windows because we pass URL arguments. So, we need to add a '--' to the arguments to work around the issue.

bendemboski added a commit to felixrieseberg/ember-electron that referenced this pull request Oct 5, 2018

Fix for testing against electron 3 on windows
electron/electron#13039 caused our tests to fail on windows because we pass URL arguments. So, we need to add a '--' to the arguments to work around the issue.
@DandroidDeveloper

This comment has been minimized.

DandroidDeveloper commented Oct 25, 2018

Do any of you know the state of --ignore-gpu-blacklist? That flag just seems to be ignored in any version past electron 2.0.0.

#15339

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Oct 26, 2018

@DandroidDeveloper This PR isn't related to the GPU blacklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment