New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove command line argument black-list #13039
Conversation
Instead block all arguments following a URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@alespergl Has it been / should it be backported to the |
electron/electron#13039 caused our tests to fail on windows because we pass URL arguments. So, we need to add a '--' to the arguments to work around the issue.
electron/electron#13039 caused our tests to fail on windows because we pass URL arguments. So, we need to add a '--' to the arguments to work around the issue.
Do any of you know the state of --ignore-gpu-blacklist? That flag just seems to be ignored in any version past electron 2.0.0. |
@DandroidDeveloper This PR isn't related to the GPU blacklist |
@alespergl is this documented? Hit an issue on Windows 10 where the arguments
caused the app to die before hitting any code in app.js. But when the args were refiddled to
or
it works. Does not seem to be a problem on Mac but will catch people out on Windows. It's also a bit unintuitive. |
Per our agreement we will instead block all arguments following a URL.
Users of apps that accept multiple URLs, or other arguments following a URL, will need to use a
--
argument as a prefix.