build: Updates to the release process #13597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2018 09:40
AppVeyor builds got split into two jobs, `electron-x64` and `electron-ia32`
Our upload script was relying on an old python script to find the GitHub release for uploading.
jkleinsc
force-pushed
the
release-updates
branch
from
a9bf4fc
to
2040095
Compare
codebytere
approved these changes
Jul 10, 2018
|
An error occurred while attempting to backport this PR to "2-0-x", you will need to perform this backport manually |
|
We have automatically backported this PR to "3-0-x", please check out #13612 |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two updates to our release process:
Adds support for running the 32-bit and 64-bit AppVeyor release builds as separate builds. The builds have already been split into separate builds, but the release process needs to be updated to accommodate this change.
The upload script (
script/upload.py) used by the release process was using an old python module to get the release information from GitHub. It also used this module to create the release if it didn't exist. This release creation isn't necessary anymore asscript/prepare-release.jsdoes this work. Also, in the last couple of releases, there was an issue where this ended up creating extra releases and uploading the files to the wrong release. This PR changes to use a new node scriptscript/find-release.jsto find the release instead.Checklist
npm testpasses