[WIP] fix: Enable PDF plugin #13760
Closed
[WIP] fix: Enable PDF plugin #13760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
features.gypi
Outdated
| @@ -4,7 +4,7 @@ | |||
| 'variables': { | |||
| 'enable_desktop_capturer%': 1, | |||
| 'enable_osr%': 0, # FIXME(alexeykuzmin) | |||
| 'enable_pdf_viewer%': 0, # FIXME(deepak1556) | |||
| 'enable_pdf_viewer%': 1, # FIXME(deepak1556) | |||
There was a problem hiding this comment.
The FIXME comment should probably be removed =)
Closed
jkleinsc
force-pushed
the
enable-pdf-plugin
branch
2 times, most recently
from
7684b18
to
47e4886
Compare
|
GN builds will need electron/pdf-viewer#14 (WIP). |
Co-authored-by: Kristine Zhang <kazhang@slack-corp.com>
jkleinsc
force-pushed
the
enable-pdf-plugin
branch
from
47e4886
to
9561738
Compare
|
As we're moving into the GN build, there will be a future PR to bring back the PDF viewer with GN. |
|
@sethlu What does GN mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12337
Resolves #14341
Checklist
npm testpassesNotes: re-enable pdf viewer