Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: [gn win] link dwmapi in component build #13773

Merged
merged 1 commit into from
Jul 25, 2018
Merged

build: [gn win] link dwmapi in component build #13773

merged 1 commit into from
Jul 25, 2018

Conversation

nornagon
Copy link
Member

This was causing an error at link time.

Checklist
  • PR description included and stakeholders cc'd
  • PR title follows semantic commit guidelines

@nornagon nornagon requested review from ZacWalk and a team July 23, 2018 17:20
@nornagon nornagon changed the title build: [gn] link dwmapi in component build build: [gn win] link dwmapi in component build Jul 24, 2018
@MarshallOfSound MarshallOfSound merged commit a01b4d7 into master Jul 25, 2018
@MarshallOfSound MarshallOfSound deleted the gn-link-dwmapi branch August 22, 2018 17:58
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacWalk ZacWalk ZacWalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @ZacWalk @MarshallOfSound