chore: ask for specific info in bug templates #14229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Aug 21, 2018
.github/ISSUE_TEMPLATE.md
Outdated
| @@ -7,11 +7,11 @@ Thanks for opening an issue! A few things to keep in mind: | |||
| - If you need general advice, join our Slack: http://atom-slack.herokuapp.com | |||
| --> | |||
|
|
|||
| * Electron version: | |||
| * Output of `electron --version`: | |||
There was a problem hiding this comment.
My concern here is this won't be their actual electron version, it will be the globally installed version rather than their locally installed version.
Maybe node_modules/.bin/electron --version
There was a problem hiding this comment.
Great point. Updating the PR to do this instead.
MarshallOfSound
requested changes
Aug 21, 2018
|
LGTM |
codebytere
approved these changes
Aug 22, 2018
MarshallOfSound
approved these changes
Aug 22, 2018
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When taking bug reports, ask for the output of
electron --versioninstead of asking for the version number. If users run this and paste it into the issue report, we'll get fewer misreported versions.We often get reports against Electron versions that don't exist or bug reports that are named almost like a brand new release but have a digit off and instead name an older beta from months ago, which is suspicious. Now that we have nightly builds and master represented as a number newer than the beta line, the confusion is likely to get worse.
thoughts, @sofianguy @codebytere ? Is this overkill?
Checklist
Release Notes
Notes: no-notes