Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't terminate existing sessions when opening devtools (3-0-x) #14566

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@deepak1556
Copy link
Member

deepak1556 commented Sep 12, 2018

Description of Change

Take advantage of devtools multiple session support. This will be fixed in master when #14522 is merged.

Fixes #14540

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: fix: don't terminate existing sessions when opening devtools

@deepak1556 deepak1556 requested a review from as a code owner Sep 12, 2018

@deepak1556 deepak1556 force-pushed the devtools_multi_session_patch_3-0-x branch from 8cb294d to d29b505 Sep 12, 2018

@deepak1556 deepak1556 force-pushed the devtools_multi_session_patch_3-0-x branch from d29b505 to e8be8cf Sep 12, 2018

@MarshallOfSound MarshallOfSound merged commit 3348e51 into 3-0-x Sep 12, 2018

13 of 16 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
appveyor: gn-win-x64-testing Waiting for AppVeyor build to complete
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: gn-win-ia32-debug AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
appveyor: gn-win-x64-debug AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Sep 12, 2018

Release Notes Persisted

fix: don't terminate existing sessions when opening devtools

@MarshallOfSound MarshallOfSound deleted the devtools_multi_session_patch_3-0-x branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.