Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ELECTRON_GN_BUILD define #14590

Merged
merged 2 commits into from
Sep 12, 2018
Merged

chore: remove ELECTRON_GN_BUILD define #14590

merged 2 commits into from
Sep 12, 2018

Conversation

nornagon
Copy link
Member

It's no longer needed now that the GN build is the only build.

  • PR description included and stakeholders cc'd
  • PR title follows semantic commit guidelines

Notes: no-notes

@nornagon nornagon requested a review from a team September 12, 2018 18:47
deepak1556
deepak1556 approved these changes Sep 12, 2018
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at this cleanup, can you remove the DISABLE_NACL define as well, we never supported it and won't be either.

codebytere
codebytere approved these changes Sep 12, 2018
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nornagon nornagon merged commit d78a2a1 into master Sep 12, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 12, 2018

No Release Notes

@nornagon nornagon deleted the remove-gn-build-define branch September 12, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nornagon @ckerr @deepak1556 @codebytere