Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: with enable_extensions=false #14657

Merged
merged 1 commit into from Sep 18, 2018
Merged

build: with enable_extensions=false #14657

merged 1 commit into from Sep 18, 2018

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Sep 18, 2018 •
edited

Description of Change

Disable //extensions layer support, we don't consume it yet.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@deepak1556 deepak1556 requested a review from a team September 18, 2018 01:19
@deepak1556 deepak1556 changed the title [WIP] build: with enable_extensions=false build: with enable_extensions=false Sep 18, 2018
ckerr
ckerr approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@codebytere codebytere merged commit b05bce1 into master Sep 18, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 18, 2018

No Release Notes

@codebytere codebytere deleted the disable_extensions branch September 18, 2018 18:05
@nornagon
Copy link
Member

The chromium patch here could probably be upstreamed.

@deepak1556
Copy link
Member Author

Yup, I will try to do it, was planning to build //chrome with this patch first before creating CL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@codebytere codebytere codebytere approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deepak1556 @nornagon @ckerr @alexeykuzmin @codebytere