Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add a branch name to Slack notifications #14793

Merged
merged 1 commit into from Sep 25, 2018
Merged

ci: add a branch name to Slack notifications #14793

merged 1 commit into from Sep 25, 2018

Conversation

alexeykuzmin
Copy link
Contributor

Description of Change

Since we now build not only from master.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no notes

@alexeykuzmin alexeykuzmin requested review from jkleinsc and a team September 25, 2018 09:03
jkleinsc
jkleinsc approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkleinsc jkleinsc merged commit c5fa7b8 into master Sep 25, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 25, 2018

Release Notes Persisted

no notes

@jkleinsc jkleinsc deleted the add-a-branch-name-to-slack-notifications branch September 25, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexeykuzmin @jkleinsc