ci: run unittests and browsertests separately #14826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @deepak1556 the native tests job should be green from now on. |
alexeykuzmin
force-pushed
the
better-native-tests
branch
from
3065b34
to
3f38b35
Compare
jkleinsc
reviewed
Sep 27, 2018
There was a problem hiding this comment.
Looks good to me, but the test run you provided (https://circleci.com/gh/electron/electron/66545) does fail with an exit code of 1:
/home/builduser/project/src/out/Default/ui_base_unittests returned 0
run: suite_returncode is 1
Exited with code 1
|
Release Notes Persisted
|
codebytere
pushed a commit
that referenced
this pull request
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
subprocess.callExample job: https://circleci.com/gh/electron/electron/66545
Checklist
npm testpassesRelease Notes
Notes: no notes