Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove //chrome/browser/icon_loader source copies #14955

Merged
merged 2 commits into from Oct 5, 2018

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Oct 3, 2018

Description of Change

Removes chromium_src/chrome/browser/icon_loader* without any functionality change.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@deepak1556 deepak1556 requested review from a team, ckerr and alexeykuzmin October 3, 2018 16:59
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@alexeykuzmin alexeykuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MarshallOfSound
Copy link
Member

I'd like to hold on this till 68 lands, I feel as though they might conflict 😄

@ckerr ckerr merged commit 2700eac into master Oct 5, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 5, 2018

No Release Notes

@ckerr ckerr deleted the icon_loader_patch branch October 5, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants