fix: Remove statSyncNoException for good
#15092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixrieseberg
commented
Oct 11, 2018
lib/common/asar.js
Outdated
| fs.statSyncNoException = pathArgument => { | ||
| const { isAsar, asarPath, filePath } = splitPath(pathArgument) | ||
| if (!isAsar) return statSyncNoException(pathArgument) | ||
| if (!isAsar) return fs.statSyncNoException(pathArgument) |
There was a problem hiding this comment.
@MarshallOfSound I'm actually not quite sure what this code is supposed to do. This would is just recursion, right?
felixrieseberg
changed the title
statSyncNoException for good
MarshallOfSound
approved these changes
Oct 11, 2018
codebytere
approved these changes
Oct 11, 2018
There was a problem hiding this comment.
@felixrieseberg rip, see #15089; we already removed it from the fork but forgot to remove it here 🙃
ty for this
This was referenced Oct 11, 2018
|
Release Notes Persisted
|
|
We have automatically backported this PR to "4-0-x", please check out #15110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The existing code throws if anasaris used. This simply changes the assignment, ensuring that the correct object is returned.New plan: Let's just cut
fs.statSyncNoExceptionfor real.Checklist
npm testpassesRelease Notes
Notes: Fix "TypeError: statSyncNoException is not a function" when asar is used