Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split out LoginItem tests to account for delay in MAS api #15135

Merged
merged 1 commit into from Oct 13, 2018
Merged

fix: split out LoginItem tests to account for delay in MAS api #15135

merged 1 commit into from Oct 13, 2018

Conversation

codebytere
Copy link
Member

Description of Change

Resolves flaky LoginItem tests on MAS builds.
Unrelated to LoginItem CI failure beginning 10.13.

/cc @MarshallOfSound @alexeykuzmin

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@codebytere codebytere requested a review from a team October 13, 2018 01:54
@MarshallOfSound MarshallOfSound merged commit 72db5ed into master Oct 13, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 13, 2018

No Release Notes

@MarshallOfSound MarshallOfSound deleted the fix-loginitem-timeout branch October 13, 2018 07:52
@trop
Copy link
Contributor

trop bot commented Oct 13, 2018

We have automatically backported this PR to "4-0-x", please check out #15142

@trop trop bot mentioned this pull request Oct 13, 2018
Merged
@trop trop bot added merged/4-0-x and removed target/4-0-x labels Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound