Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: honor dialog.showMessageBox()'s Icon argument on Linux (backport: 2-0-x) #15341

Merged
merged 3 commits into from Oct 23, 2018
Merged

fix: honor dialog.showMessageBox()'s Icon argument on Linux (backport: 2-0-x) #15341

merged 3 commits into from Oct 23, 2018

Commits on Oct 23, 2018

  1. Don't call gtk_widget_show_all() on popup dialog. 

    Fixes electron#15317.

Notes: Fixed incorrect display of some GtkMessageDialog icons.

The issue is caused because GtkMessageDialog contains an icon widget
which is not shown when there's no associated icon. Our call to
`gtk_widget_show_all()` overrides this, showing the uninitialized
icon widget.

This PR fixes the issue by calling `gtk_widget_show()` where needed
and removing use of `gtk_widget_show_all()` in the message dialog.
    @ckerr @electron-bot
    ckerr authored and electron-bot committed Oct 23, 2018
    Copy the full SHA
    4579117 View commit details
    Browse the repository at this point in the history

  2. use gtk_dialog_set_default_response() for default

    @ckerr @electron-bot
    ckerr authored and electron-bot committed Oct 23, 2018
    Copy the full SHA
    950be40 View commit details
    Browse the repository at this point in the history

  3. fix: support icons on gtk+ messageboxes.

    @ckerr @electron-bot
    ckerr authored and electron-bot committed Oct 23, 2018
    Copy the full SHA
    bc617b5 View commit details
    Browse the repository at this point in the history