Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors in preload script instead of rethrowing #1551

Merged
merged 1 commit into from
May 4, 2015

Conversation

anaisbetts
Copy link
Contributor

At some point, unhandled errors in preload scripts stopped being logged to console, meaning that preload scripts were very difficult to debug. Instead, print the error to console (which is what we wanted to have happen anyways)

To repro the bug:

  1. Create a page with a WebView that has a preload script
  2. In the preload script, throw an error for whatever reason (syntax error, etc)
  3. Script silently stops and the page loads but the script didn't execute

At some point, unhandled errors in preload scripts stopped being logged
to console, meaning that preload scripts were very difficult to debug.
Instead, print the error to console (which is what we wanted to have
happen anyways)
@zcbenz
Copy link
Member

zcbenz commented May 4, 2015

👍

zcbenz added a commit that referenced this pull request May 4, 2015
Log errors in preload script instead of rethrowing
@zcbenz zcbenz merged commit 1835d90 into master May 4, 2015
@zcbenz zcbenz deleted the log-preload-errors branch May 4, 2015 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants