Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore //url dchecks #15637

Merged
merged 4 commits into from
Nov 22, 2018
Merged

chore: restore //url dchecks #15637

merged 4 commits into from
Nov 22, 2018

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Nov 8, 2018

Re-enable DCHECKs in //url

Notes: no-notes

@nornagon nornagon requested a review from a team November 8, 2018 02:01
@nornagon nornagon changed the title chore: restore //url dchecks [wip] chore: restore //url dchecks Nov 8, 2018
@nornagon
Copy link
Member Author

nornagon commented Nov 8, 2018

[wip] because of the scheme registries failures

@nornagon nornagon changed the title [wip] chore: restore //url dchecks chore: restore //url dchecks Nov 21, 2018
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nornagon nornagon merged commit a8a881c into master Nov 22, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 22, 2018

No Release Notes

@codebytere codebytere deleted the restore-url-dchecks branch January 4, 2019 16:27
bcpete pushed a commit to bcpete/electron that referenced this pull request Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants