Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add numpad keyboard mappings #15689

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Nov 12, 2018

Description of Change

Refs: #11310.

Adds numpad mappings to our keyboard shortcuts list to allow for their use in accelerators.

/cc @brenca

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Allow numpad keys to be used as accelerators.

@codebytere codebytere requested a review from as a code owner Nov 12, 2018

@codebytere codebytere changed the title feat: add numpad keyboard mappings [WIP] feat: add numpad keyboard mappings Nov 12, 2018

@codebytere codebytere force-pushed the numpad-mappings branch from 59b2f17 to 6181794 Nov 13, 2018

@codebytere codebytere requested a review from as a code owner Nov 13, 2018

@codebytere codebytere changed the title [WIP] feat: add numpad keyboard mappings feat: add numpad keyboard mappings Nov 13, 2018

Show resolved Hide resolved atom/common/keyboard_util.cc

@codebytere codebytere force-pushed the numpad-mappings branch from bf74629 to 83a526b Nov 13, 2018

@ckerr

ckerr approved these changes Nov 14, 2018

@codebytere codebytere merged commit 511dc9a into master Nov 14, 2018

22 of 25 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
electron-mas-testing Build #20181113.30 has failed
Details
electron-osx-testing Build #20181113.31 has failed
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181113.15 succeeded
Details
electron-arm64-testing Build #20181113.15 succeeded
Details
electron-lint Build #20181113.24 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 14, 2018

Release Notes Persisted

Allow numpad keys to be used as accelerators.

@ckerr ckerr deleted the numpad-mappings branch Nov 14, 2018

neo291 added a commit to neo291/electron that referenced this pull request Nov 16, 2018

neo291 added a commit to neo291/electron that referenced this pull request Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.