New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deprecate options in webcontents.findInPage #15735
Conversation
lib/browser/api/web-contents.js
Outdated
@@ -288,6 +288,13 @@ WebContents.prototype.getZoomFactor = function (callback) { | |||
}) | |||
} | |||
|
|||
WebContents.prototype.findInPage = function (text, options = {}) { | |||
//TODO (nitsakh): Remove in 5.0 | |||
if (options.wordStart || options.medialCapitalAtWordStart) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (options.wordStart || options.medialCapitalAtWordStart) | |
if (options.wordStart != null || options.medialCapitalAtWordStart != null) |
this will catch potential usages where the app passes false
in some cases (e.g. when developer is testing) but true
in other cases (e.g. when user flips some option)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving for merge!
Merging this as macos CI failures are unrelated. |
Release Notes Persisted
|
Description of Change
medialCapitalAsWordStart
andwordStart
are removed upstream (e6cb6f2).So lets deprecate them in 4.x and remove in 5.x.
Checklist
npm test
passesRelease Notes
Notes: Deprecated
findInPage
optionswordStart
andmedialCapitalAsWordStart