view: add ResizeArea class #15752
Merged
view: add ResizeArea class #15752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
Nov 19, 2018
| // Constructor call. | ||
| auto* view = new ResizeArea(); | ||
| view->InitWith(args->isolate(), args->GetThis()); | ||
| return view; |
There was a problem hiding this comment.
I'm confused how ResizeArea can be cast to mate::WrappableBase given that it doesn't inherit from mate::Wrappable?
There was a problem hiding this comment.
This class inherits from api::View, which inherits from mate::Wrappable.
There was a problem hiding this comment.
oh, d'oh, I thought View was views::View. Confusing.
nornagon
approved these changes
Nov 20, 2018
|
No Release Notes |
|
FYI use the string |
bcpete
pushed a commit
to bcpete/electron
that referenced
this pull request
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add JS bindings for the
views::ResizeAreaclass:https://cs.chromium.org/chromium/src/ui/views/controls/resize_area.h?sq=package:chromium&g=0&l=18
Hidden by the
enable_view_apiflag.Notes: no-notes