Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Windows build instructions to include debugging tools #15765

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

BinaryMuse
Copy link
Contributor

Description of Change

On my machine, I had to go through extra steps to get the SDK Debugging Tools installed.

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@BinaryMuse BinaryMuse requested a review from a team November 19, 2018 21:01
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BinaryMuse BinaryMuse changed the title doc: Update Windows build instructions to include debugging tools doc: update Windows build instructions to include debugging tools Nov 19, 2018
@nornagon
Copy link
Member

Is there any other stuff we should copy over from https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md?

@codebytere codebytere changed the title doc: update Windows build instructions to include debugging tools docs: update Windows build instructions to include debugging tools Nov 20, 2018
@codebytere codebytere merged commit 46c2953 into master Nov 20, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 20, 2018

No Release Notes

@codebytere codebytere deleted the mkt/add-debugging-tools-to-windows-docs branch January 4, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants