chore: remove no_stack_dumping.patch #15785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we build with IS_OFFICIAL_BUILD now so this should be OK
zcbenz
approved these changes
Nov 21, 2018
codebytere
approved these changes
Nov 21, 2018
|
No Release Notes |
|
This enables stack dumping in non-official builds, and it seems we don't want them in arm for certain crash https://github.com/electron/electron/blob/master/atom/app/atom_main_delegate.cc#L159-L170 ? Should that be removed now ? FWIW, the CI doesn't seem to crash. |
|
If this causes an issue in debug mode on certain architectures we can disable it with |
|
Yes, the code in https://github.com/electron/electron/blob/master/atom/app/atom_main_delegate.cc#L159-L170 , should be simplified now, as its redundant for non-official builds. |
nornagon
added a commit
that referenced
this pull request
Nov 29, 2018
2 tasks
nornagon
added a commit
that referenced
this pull request
Nov 29, 2018
bcpete
pushed a commit
to bcpete/electron
that referenced
this pull request
Apr 18, 2019
we build with IS_OFFICIAL_BUILD now so this should be OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we build with IS_OFFICIAL_BUILD now so this should be OK
Release Notes
Notes: no-notes