chore: remove browser_plugin_guest.patch #15786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Nov 21, 2018
codebytere
approved these changes
Nov 21, 2018
|
The code path is still hot after moving to OOPIF based webview implementation, because the state on the browser process side are still tracked through browser plugin. Not sure how the original crash was found electron/libchromiumcontent#399, so don't have much info on whether this is completely fixed. |
|
I looked through some of the code leading to that function and it's unclear to me how it could ever be null. IMO let's not keep patches around out of superstition—if the crash resurfaces, we can restore this patch (or, better, fix it without patching 😁). |
|
No Release Notes |
bcpete
pushed a commit
to bcpete/electron
that referenced
this pull request
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
doesn't appear to be necessary any more, & doesn't have a description of why it's needed. /cc @torycl
Release Notes
Notes: no-notes