Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: eliminate duplicate code exposing process APIs #15824

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
5 participants
@miniak
Copy link
Contributor

commented Nov 24, 2018

Description of Change

  • Eliminate duplicate code exposing process APIs (sandboxed vs non-sandboxed renderer).
  • Expose missing process.getCreationTime() in sandboxed renderers.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Missing process.getCreationTime() exposed in sandboxed renderers.

@miniak miniak requested review from as code owners Nov 24, 2018

@miniak miniak force-pushed the miniak/process branch 3 times, most recently from 811701d to 5faa873 Nov 24, 2018

@miniak miniak self-assigned this Nov 26, 2018

@nornagon
Copy link
Contributor

left a comment

LGTM but please add a comment!

Show resolved Hide resolved atom/common/api/atom_bindings.cc

@miniak miniak force-pushed the miniak/process branch from 5faa873 to 12b58ac Nov 26, 2018

@zcbenz

zcbenz approved these changes Nov 27, 2018

@miniak miniak force-pushed the miniak/process branch from 12b58ac to 79a9608 Nov 28, 2018

@codebytere codebytere merged commit 07f8f5f into master Nov 28, 2018

26 of 27 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181128.11 succeeded
Details
electron-arm64-testing Build #20181128.11 succeeded
Details
electron-lint Build #20181128.12 succeeded
Details
electron-mas-testing Build #20181128.12 succeeded
Details
electron-osx-testing Build #20181128.13 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 28, 2018

Release Notes Persisted

Missing process.getCreationTime() exposed in sandboxed renderers.

@codebytere codebytere deleted the miniak/process branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.