chore: make rpc-server reply to sender frame instead of the main frame #15973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Dec 7, 2018
Co-Authored-By: zcbenz <zcbenz@github.com>
codebytere
approved these changes
Dec 9, 2018
|
No Release Notes |
MarshallOfSound
pushed a commit
that referenced
this pull request
Jan 27, 2019
#15973) * chore: make rpc-server reply to frame * fix: check IsRenderFrameLive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add
WebContents._sendToFrameInternalAPI, and makerpc-serveruse it to reply to the sender frame instead of always replying to the main frame.This PR does not have any change to behaviors, it is just one step to make
remotefriendly to multi-frames in one process.As side effect,
callIntoRendererbecomes more efficient when sending messages to a destroyed frame.See #15894 (review) for the motivation.
Checklist
npm testpassesRelease Notes
Notes: no-notes